Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| Name | Type |
|---|---|
| @cube-dev/ui-kit | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-7298754. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk because it changes
FilterListBoxfiltering and virtual-focus behavior (especially withallowsCustomValue+filter={false}), which can affect keyboard navigation and item visibility across multiple consumer flows.Overview
Simplifies
isLoadingItemsUX forFilterPicker/FilterListBox: removes the in-popover loading disclaimer andloadingItemsLabel, and instead shows a subtle spinner in the search input suffix;FilterPickerno longer shows a trigger loading icon forisLoadingItems.Refines server-side search behavior (
filter={false}): whileisLoadingItemsis true, non-matching stale items are temporarily hidden usingcontains, and locally-injected selected custom values now always respect the search term even when parent filtering is disabled.Improves custom-value virtual focus: updates focus targeting so when no matches exist (including during in-flight fetches) focus moves/stays on the new custom-value option, and when matches arrive it prefers the first real item. Also unifies
emptyLabelso a provided value overrides both the “No items” and “No results found” defaults.Reviewed by Cursor Bugbot for commit 8439303. Bugbot is set up for automated code reviews on this repo. Configure here.